Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address warnings for logger and ostruct #100

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Address warnings for logger and ostruct #100

merged 2 commits into from
Oct 18, 2024

Conversation

yuki24
Copy link
Contributor

@yuki24 yuki24 commented Oct 12, 2024

There are a few warnings displayed when I run the bundle exec rake command:

flatware/spec/spec_helper.rb:3: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.

gems/cucumber-3.2.0/lib/cucumber/formatter/legacy_api/adapter.rb:9: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.

We can address these by adding loggee and ostruct to the Gemfile.

There are other warnings from Cucumber, but that's not something we can address from outside of the dependency.

briandunn
briandunn reviewed Oct 18, 2024
View reviewed changes
Copy link
Owner

@briandunn briandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@briandunn briandunn merged commit 42c398d into briandunn:master Oct 18, 2024
24 checks passed
@yuki24 yuki24 deleted the yuki24/chore/address-warnings branch October 19, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandunn briandunn briandunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki24 @briandunn